Cleanup error handling in format_strings.cpp #2958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisr-diffblue
requested review from
kroening,
peterschrammel,
pkesseli,
smowton and
tautschnig
as code owners
allredj
reviewed
Sep 14, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 1dd6f70).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84841239
peterschrammel
approved these changes
Sep 17, 2018
kroening
reviewed
Sep 18, 2018
| throw std::string("unsupported format conversion specifier: `")+*it+"'"; | ||
| throw deserialization_exceptiont( | ||
| std::string("unsupported format conversion specifier: `") + *it + "'"); | ||
| } |
Collaborator
There was a problem hiding this comment.
This is entirely unrelated to deserialisation.
Collaborator
|
The system_error_exception introduced here appears to be unrelated to anything in format_strings.cpp. |
chrisr-diffblue
force-pushed
the
cleanup-format_strings
branch
from
1dd6f70 to
fead175
Compare
Contributor
Author
|
Rebased to pickup newer exception classes and now using one of the new exception classes as a more appropriate exception type. |
tautschnig
approved these changes
Sep 20, 2018
allredj
reviewed
Sep 20, 2018
Contributor
allredj
left a comment
allredj
left a comment
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: fead175).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85445548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.