Skip to content

Conversation

majakusber
Copy link

This is part of the typet cleanup, based on top of #2815, please review only the last commit.

@thk123
Copy link
Contributor

thk123 commented Aug 23, 2018

Don't merge until #2815 is merged.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 426debe).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84533893

@majakusber
Copy link
Author

#2815 is merged now, rebased on develop.

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 4f03876).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85007182
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 0374018).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85011006

@majakusber majakusber merged commit 13360bf into diffblue:develop Sep 17, 2018
@majakusber majakusber deleted the deprecate_nil_typet branch September 17, 2018 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants