Skip to content

Correct incomplete_array_typet [DOC-12] #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 17, 2018
Merged

Correct incomplete_array_typet [DOC-12] #2820

merged 2 commits into from
Sep 17, 2018

Conversation

majakusber
Copy link

@majakusber majakusber commented Aug 22, 2018 •
edited
Loading

This is part of the typet cleanup, based on top of #2815, please review only the last two commits.

@majakusber majakusber self-assigned this Aug 22, 2018
@majakusber majakusber mentioned this pull request Aug 22, 2018
Merged
@majakusber majakusber force-pushed the correct_incomplete_array branch from 3b73b99 to d06b021 Compare August 22, 2018 15:00
@tautschnig
Copy link
Collaborator

Happy to approve once the depended-on commits are merged.

@majakusber majakusber force-pushed the correct_incomplete_array branch from d06b021 to 56dd9b2 Compare August 22, 2018 16:02
thk123
thk123 approved these changes Aug 23, 2018
View reviewed changes
Copy link
Contributor

@thk123 thk123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this passes CI and once preceding PR has been merged

src/util/std_types.h Outdated

explicit incomplete_array_typet(const typet &_subtype):
type_with_subtypet(ID_array, _subtype)
explicit incomplete_array_typet(const typet &_subtype)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this is a change in behaviour - have you checked that this constructor wasn't used anywhere? CLion says no, so you might just like to delete it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it's not used indeed, removed.

@majakusber majakusber force-pushed the correct_incomplete_array branch from 56dd9b2 to 6abec05 Compare September 11, 2018 16:43
allredj
allredj reviewed Sep 11, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: 6abec05).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/84464293

@majakusber majakusber force-pushed the correct_incomplete_array branch from 6abec05 to 5660eea Compare September 17, 2018 12:42
@majakusber majakusber force-pushed the correct_incomplete_array branch from 5660eea to ff5a232 Compare September 17, 2018 13:25
@majakusber
Copy link
Author

#2815 is merged now, rebased on develop.

allredj
allredj reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR failed Diffblue compatibility checks (cbmc commit: 5660eea).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85007431
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.

Common spurious failures:

  • the cbmc commit has disappeared in the mean time (e.g. in a force-push)
  • the author is not in the list of contributors (e.g. first-time contributors).

allredj
allredj reviewed Sep 17, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: ff5a232).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/85009844

@majakusber majakusber merged commit 5f4f3d4 into diffblue:develop Sep 17, 2018
@majakusber majakusber deleted the correct_incomplete_array branch September 17, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peterschrammel peterschrammel peterschrammel approved these changes

@cesaro cesaro Awaiting requested review from cesaro

@cristina-david cristina-david Awaiting requested review from cristina-david

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@mgudemann mgudemann Awaiting requested review from mgudemann

@NathanJPhillips NathanJPhillips Awaiting requested review from NathanJPhillips

@pkesseli pkesseli Awaiting requested review from pkesseli

@smowton smowton Awaiting requested review from smowton

@tautschnig tautschnig Awaiting requested review from tautschnig tautschnig is a code owner

+2 more reviewers

@allredj allredj allredj left review comments

@thk123 thk123 thk123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@majakusber majakusber

Labels

bugfix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@majakusber @tautschnig @thk123 @peterschrammel @allredj