Comments not in UTF-8 - error with newer versions of LLVM #7509
Description
CBMC version: 5.75.0
Operating system: MacOS 10.15.7
Exact command line resulting in the issue: cmake --build build -- -j 8
What behaviour did you expect: Successful build
What happened instead: clang error: cbmc-git/src/big-int/bigint-func.cc:5:9: error: invalid UTF-8 in comment [-Werror,-Winvalid-utf8]
The offending character is a ü.
I was having trouble building with Homebrew (which might be on me for using an unsupported version of MacOS) so I followed the compiling instructions included in the repo.
It looks like clang has recently added a new warning for non-UTF-8 comments:
https://reviews.llvm.org/D128059
I'm guessing that the encoding used in the source files is Windows-1252 -- I haven't tried converting the source files yet -- but since clang has added this compiler warning (or in my case an error due to the -Werror flag), I figure there either needs to be a change in CMakeLists.txt or in the source file encoding so that folks can compile without issue.