Support linting even from the master branch #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterschrammel
approved these changes
Aug 23, 2021
viktormalik
reviewed
Aug 23, 2021
|
Or, alternatively, run the job for pull requests only. |
FrNecas
force-pushed
the
frnecas-lint-fix
branch
from
512ebae to
1639502
Compare
|
I think running for push makes sense - you can easily see the style errors before opening a pull request. Lets ignore only pushes to master |
FrNecas
force-pushed
the
frnecas-lint-fix
branch
from
1639502 to
f85c7f5
Compare
Signed-off-by: František Nečas <[email protected]>
FrNecas
force-pushed
the
frnecas-lint-fix
branch
from
f85c7f5 to
764a60c
Compare
|
Should be excluded now, tested on my fork (https://github.com/FrNecas/2ls) |
viktormalik
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The action would fail after a pull request is merged into master due to the
git fetchcommand which refuses to fetch the current branch.