Bump all generated-file and reviewed-file DFXML version references #45
Conversation
This patch clears TODOs that noted certain branches needed to merge in to the schema. Given the schema testing being used in file generation--parse round-tripping, all branches are assumed to have been merged. Signed-off-by: Alex Nelson <[email protected]>
|
Absent feedback, I will merge this change Tuesday morning. |
simsong
left a comment
simsong
left a comment
There was a problem hiding this comment.
I recommend putting all of the version numbers in a single place, perhaps a file called constants.py in a class called C. Like this:
https://github.com/Plant-Tracer/webapp/blob/main/constants.py
it will make it easier to maintain...
|
|
||
| def test_blank_file_object_filename() -> None: | ||
| dobj = Objects.DFXMLObject(version="1.2.0") | ||
| dobj = Objects.DFXMLObject(version="2.0.0-beta.0") |
There was a problem hiding this comment.
Should we have all of these strings in a single location?
There was a problem hiding this comment.
I'll put the value into /dfxml/__init__.py, next to the XMLNS constants.
I think I'll also just have the version keyword argument default to that constant string.
There was a problem hiding this comment.
I want a single constant string... Should I wait off on merging this?
There was a problem hiding this comment.
Yes, please. I was mid-stream on something else, will handle now.
There was a problem hiding this comment.
This is addressed now. If you have no other feedback, I'm fine with this being merged at your convenience.
Signed-off-by: Alex Nelson <[email protected]>
This PR clears TODOs that noted certain branches needed to merge in to the schema. Given the schema testing being used in file generation--parse round-tripping, all branches are assumed to have been merged.