Skip to content

fig keyword allows m^2 fig.axes, if m>=n sample dims. #280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fig keyword allows m^2 fig.axes, if m>=n sample dims. #280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71ad2f3
fig keyword allows m^2 fig.axes, if m>=n sample dims.
fdeugenio Nov 6, 2024
a9a6633
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 13 additions & 8 deletions src/corner/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -904,16 +904,21 @@ def _parse_input(xs):
def _get_fig_axes(fig, K):
if not fig.axes:
return fig.subplots(K, K), True
try:
axarr = np.array(fig.axes).reshape((K, K))
return axarr.item() if axarr.size == 1 else axarr.squeeze(), False
except ValueError:

axarr = np.array(fig.axes)
axarr_size = axarr.size
if np.sqrt(axarr_size) != int(np.sqrt(axarr_size)):
raise ValueError(
(
"Provided figure has {0} axes, but data has "
"dimensions K={1}"
).format(len(fig.axes), K)
f"Provided figure has {axarr_size} axes. Must be a square number"
)
if axarr.size == K**2:
axarr = np.array(fig.axes).reshape((K, K))
return axarr.item() if axarr.size == 1 else axarr.squeeze(), False
if axarr.size > K**2:
axarr_ndim = int(np.sqrt(axarr_size))
axarr = axarr.reshape((axarr_ndim, axarr_ndim)) # Reshape to square
axarr = axarr[:K, :K]
return axarr.squeeze(), False


def _set_xlim(force, new_fig, ax, new_xlim):
Expand Down