Errors in titles unaffected by quantiles argument

[geoffrey4444]

The help text (corner.py, line 65) says

show_titles : bool
Displays a title above each 1-D histogram showing the 0.5 quantile
with the upper and lower errors supplied by the quantiles argument.

but actually the errors in the titles are not affected by the quantiles argument (corner.py, line 269) but instead are hard-coded:

q_16, q_50, q_84 = quantile(x, [0.16, 0.5, 0.84],
weights=weights)
q_m, q_p = q_50-q_16, q_84-q_50

            # Format the quantile display.
            fmt = "{{0:{0}}}".format(title_fmt).format
            title = r"${{{0}}}_{{-{1}}}^{{+{2}}}$"
            title = title.format(fmt(q_50), fmt(q_m), fmt(q_p))

Shouldn't the the array passed to quantile use the quantiles argument for the lower and upper bounds? If not, shouldn't the help text say that the errors are hard-coded to the 68% confidence region?

[dfm]

That is definitely not good! I don't think that it's a good idea to use the quantiles argument directly because it could have an arbitrary number of values but the wording of the docstring should be corrected. Do you want to open a pull request with a fix?

[geoffrey4444]

Thanks for the quick reply! What if you used the smallest and largest of the quantiles given for the errors? If you like that idea, I'll see if I or one of my students can open a pull request, once we've implemented a fix along those lines.

[dfm]

I'd rather have a completely separate argument because I expect that I would often like this level of control. A fix would be much appreciated!