add browser specific version #7
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlobeltrame
added a commit
to carlobeltrame/react-pdf
that referenced
this pull request
Jun 16, 2022
Adaptations taken from devongovett/blob-stream#7 which is unlikely to ever get merged, judging from the fact that the package has not been updated since 2014. blob-stream is only used in the web version of react-pdf, so it is safe to directly use stream-browserify, because it will never be used on node.
8 tasks
|
Awesome, I guess your PR solves this issue then:
have you published your changes with another alias? |
|
I did not. I'm also no longer working with this package. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
Not sure if this is the best approach. I tried to keep the changes to a minimum. I resolved the dependency on module "stream" by depending on "stream-browserify" and the dependency on "util" by using the "inherits"-packages (which is also used by stream-browserify, see package.json).