Skip to content

Conversation

@denise-khuu
Copy link
Contributor

No description provided.

@denise-khuu denise-khuu linked an issue Dec 15, 2020 that may be closed by this pull request
@denise-khuu denise-khuu changed the title WIP: ChangeFile for Katacoda WIP: feature/katacodachangefile Dec 16, 2020
@denise-khuu denise-khuu changed the title WIP: feature/katacodachangefile feature/katacodachangefile Dec 16, 2020
#### details
##### Name of the placeholder
Naming Convention
[Comment-Syntax]PLACEHOLDER-[ATTRIBUTE]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe better name the last part 'DESCRIPTION'. The placeholder can stand for anything, not just for attributes

let content = "";

if(command.parameters[2].content){
content = command.parameters[2].content
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing semicolon

@denise-khuu denise-khuu requested a review from maybeec December 16, 2020 15:15
@maybeec maybeec merged commit f013721 into devonfw-tutorials:main Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

katacoda runner: changeFile

3 participants