feature/consoleCreateFile #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GuentherJulian
changed the title
maybeec
previously approved these changes
Dec 9, 2020
|
please resolve conflicts |
maybeec
previously approved these changes
Dec 9, 2020
|
again conflicts :D seems, that this design of the index.ts is not nice :D |
maybeec
approved these changes
Dec 9, 2020
denise-khuu
reviewed
Dec 22, 2020
| let result = new RunResult(); | ||
| result.returnCode = 0; | ||
|
|
||
| let workspaceDir = path.join(this.getWorkingDirectory(), "devonfw", "workspaces", "main"); |
There was a problem hiding this comment.
Path of the file to be created (relative path to the workspace directory)
should be (relative path to /root). We would have to change it here, too.
@GuentherJulian
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.