Skip to content

Conversation

@denise-khuu
Copy link
Contributor

createProject() was added and changeCurrentDir was used in previous functions when needed.
Still need to add dynamically changing cd template, based on current dir.

@denise-khuu denise-khuu linked an issue Nov 23, 2020 that may be closed by this pull request
@denise-khuu denise-khuu reopened this Nov 24, 2020
@maybeec
Copy link
Member

maybeec commented Dec 3, 2020

@denise-khuu , @GuentherJulian as of my comments in https://github.com/devonfw-forge/tutorial-compiler/pull/38/files#r534927014 I feel, that we have to create multiple steps for each type of project we want to create.

The reason behind that is quite easy. Here you created a generic createProject step, which a parameter for the language.
The problem with that is, that the project generation will differ tremendously is each stack obviously. So also the katacoda templates etc will describe completely different things. In addition, each project creation might come with a complete different set of parameters to customize the project creation. So there is no "common code" at all I feel, which simply leads to a very complex step implementation with lots of case differentiation.
Finally, the last point here is, that there might be even multiple templates (per architecture) for one programming language. So just differentiating the project creation based on the programming language will not work.

So for me as you already started with it, I would propose to simply remove the first parameter of the step and simply rename the createProject step to createDevon4jProject and then also the katacoda template and so on is fine as it focuses on the steps for that generation only.

@maybeec maybeec dismissed SchettlerKoehler’s stale review December 4, 2020 10:18

comments covered; dismiss as on leave

@maybeec
Copy link
Member

maybeec commented Dec 9, 2020

Please resolve conflicts

@denise-khuu denise-khuu requested a review from maybeec December 9, 2020 10:43
@maybeec maybeec merged commit cc99151 into devonfw-tutorials:main Dec 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

katacoda runner: createProject

4 participants