fix: update processLoginCallbacks to use sessionDuration instead of r… #411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
requested changes
Oct 28, 2025
| * @param adminUser - plugin/af pases current adminUser | ||
| * @param toReturn - this is an object which will get status of login process. If at least one callback returns error or redirectTo, login process will be stopped (future callbacks will not be called). | ||
| * @param response - http response object | ||
| * @param sessionDuration - duration of session in days |
There was a problem hiding this comment.
@SerVitasik I thought we agreed on using :"compact string literals" (Go/Prometheus-style) like '1m', '2h' '3d', '1m' etc. As I said short durations might be pretty preferred for fin sector so lets rework it now to not migrate in future.
If it is number then variable name should indicate what measure it had (.e.g. sessionDurationDays) but it is better have time-string syntax
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ememberMeDays