fix: fix filter by autogenerated _id for mongodb #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivictbor
requested changes
Apr 9, 2025
adminforth/dataConnectors/mongo.ts
Outdated
| return value?.toString(); | ||
| } else if (field.name === '_id' && !field.fillOnCreate) { | ||
| // if "_id" was created by mongo it will be ObjectId | ||
| return value?.toString(); |
There was a problem hiding this comment.
@Astaldos I am a little bit afraid of case if user returns bson object from fillOnCreate.
Maybe it is better to check it like if type of value is object then do .toString(), is it safe or you see any potential issues with it?
adminforth/dataConnectors/mongo.ts
Outdated
| return Decimal128.fromString(value?.toString()); | ||
| } else if (field.name === '_id' && !field.fillOnCreate) { | ||
| // if "_id" was created by mongo it supposed to be saved as ObjectId | ||
| return ObjectId.createFromHexString(value); |
There was a problem hiding this comment.
same here, we can check if value is type of string or number or null or undefined, then wrap it in bson Object id, otherwise pass "as is"
ivictbor
requested changes
Apr 11, 2025
| return !!value; | ||
| } else if (field.type == AdminForthDataTypes.DECIMAL) { | ||
| return value?.toString(); | ||
| } else if (field.name === '_id' && !field.fillOnCreate) { |
There was a problem hiding this comment.
@Astaldos will it brake something if we will remove && !field.fillOnCreate? I mean for the case if user returns object id in fillOnCreate.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.