Skip to content
This repository was archived by the owner on Sep 4, 2021. It is now read-only.
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

# Xcode
#
build/
# build/
*.pbxuser
!default.pbxuser
*.mode1v3
Expand All @@ -31,7 +31,7 @@ local.properties
local.properties
.idea/workspace.xml
.idea/libraries
build
# build
captures

# Built application files
Expand Down
4 changes: 2 additions & 2 deletions .npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ example

# Xcode
#
build/
# build/
*.pbxuser
!default.pbxuser
*.mode1v3
Expand All @@ -35,7 +35,7 @@ local.properties
local.properties
.idea/workspace.xml
.idea/libraries
build
# build
captures

# node.js
Expand Down
13 changes: 7 additions & 6 deletions android/src/main/java/co/apptailor/Worker/WorkerModule.java
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,13 @@
import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactPackage;
import com.facebook.react.bridge.JSBundleLoader;
import com.facebook.react.cxxbridge.JSBundleLoader;
import com.facebook.react.bridge.LifecycleEventListener;
import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.devsupport.DevSupportManager;
import com.facebook.react.devsupport.interfaces.DevSupportManager;

import java.io.File;
import java.io.IOException;
Expand Down Expand Up @@ -66,6 +66,7 @@ public void startWorker(final String jsFileName, final Promise promise) {
ReactContextBuilder workerContextBuilder = new ReactContextBuilder(getReactApplicationContext())
.setJSBundleLoader(bundleLoader)
.setDevSupportManager(getDevSupportManager())
.setReactInstanceManager(getReactInstanceManager())
.setReactPackages(workerPackages);

JSWorker worker = new JSWorker(jsFileSlug);
Expand Down Expand Up @@ -134,9 +135,9 @@ public void onHostPause() {
new Handler(Looper.getMainLooper()).post(new Runnable() {
@Override
public void run() {
for (int workerId : workers.keySet()) {
workers.get(workerId).onHostPause();
}
// for (int workerId : workers.keySet()) {
// workers.get(workerId).onHostPause();
// }
}
});
}
Expand Down Expand Up @@ -177,7 +178,7 @@ private JSBundleLoader createDevBundleLoader(String jsFileName, String jsFileSlu

private JSBundleLoader createReleaseBundleLoader(String jsFileName, String jsFileSlug) {
Log.d(TAG, "createReleaseBundleLoader - reading file from assets");
return JSBundleLoader.createFileLoader(getReactApplicationContext(), "assets://workers/" + jsFileSlug + ".bundle");
return JSBundleLoader.createFileLoader("assets://workers/" + jsFileSlug + ".bundle");
}

private ReactInstanceManager getReactInstanceManager() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ public List<NativeModule> createNativeModules(ReactApplicationContext catalystAp
new ExceptionsManagerModule(reactInstanceManager.getDevSupportManager()),
new Timing(catalystApplicationContext, reactInstanceManager.getDevSupportManager()),
new UIManagerStubModule(catalystApplicationContext),
new SourceCodeModule(reactInstanceManager.getSourceUrl()),
new SourceCodeModule(catalystApplicationContext),
new JSCHeapCapture(catalystApplicationContext),

// Main list
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,21 +2,23 @@

import android.content.Context;

import com.facebook.react.NativeModuleRegistryBuilder;
import com.facebook.react.ReactPackage;
import com.facebook.react.bridge.CatalystInstance;
import com.facebook.react.bridge.CatalystInstanceImpl;
import com.facebook.react.bridge.JSBundleLoader;
import com.facebook.react.bridge.JSCJavaScriptExecutor;
import com.facebook.react.bridge.JavaScriptExecutor;
import com.facebook.react.cxxbridge.CatalystInstanceImpl;
import com.facebook.react.cxxbridge.JSBundleLoader;
import com.facebook.react.cxxbridge.JSCJavaScriptExecutor;
import com.facebook.react.cxxbridge.JavaScriptExecutor;
import com.facebook.react.bridge.JavaScriptModule;
import com.facebook.react.bridge.JavaScriptModuleRegistry;
import com.facebook.react.bridge.NativeModule;
import com.facebook.react.bridge.NativeModuleCallExceptionHandler;
import com.facebook.react.bridge.NativeModuleRegistry;
import com.facebook.react.cxxbridge.NativeModuleRegistry;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.bridge.WritableNativeMap;
import com.facebook.react.bridge.queue.ReactQueueConfigurationSpec;
import com.facebook.react.devsupport.DevSupportManager;
import com.facebook.react.devsupport.interfaces.DevSupportManager;
import com.facebook.soloader.SoLoader;

import java.util.ArrayList;
Expand All @@ -27,6 +29,7 @@ public class ReactContextBuilder {
private Context parentContext;
private JSBundleLoader jsBundleLoader;
private DevSupportManager devSupportManager;
private ReactInstanceManager instanceManager;
private ArrayList<ReactPackage> reactPackages;

public ReactContextBuilder(Context context) {
Expand All @@ -44,13 +47,18 @@ public ReactContextBuilder setDevSupportManager(DevSupportManager devSupportMana
return this;
}

public ReactContextBuilder setReactInstanceManager(ReactInstanceManager manager) {
this.instanceManager = manager;
return this;
}

public ReactContextBuilder setReactPackages(ArrayList<ReactPackage> reactPackages) {
this.reactPackages = reactPackages;
return this;
}

public ReactApplicationContext build() throws Exception {
JavaScriptExecutor jsExecutor = new JSCJavaScriptExecutor.Factory().create(new WritableNativeMap());
JavaScriptExecutor jsExecutor = new JSCJavaScriptExecutor.Factory(new WritableNativeMap()).create();

// fresh new react context
final ReactApplicationContext reactContext = new ReactApplicationContext(parentContext);
Expand All @@ -59,7 +67,7 @@ public ReactApplicationContext build() throws Exception {
}

// load native modules
NativeModuleRegistry.Builder nativeRegistryBuilder = new NativeModuleRegistry.Builder();
NativeModuleRegistryBuilder nativeRegistryBuilder = new NativeModuleRegistryBuilder(reactContext, this.instanceManager, false);
addNativeModules(reactContext, nativeRegistryBuilder);

// load js modules
Expand Down Expand Up @@ -134,12 +142,12 @@ private void addJSModules(JavaScriptModuleRegistry.Builder jsModulesBuilder) {
}
}

private void addNativeModules(ReactApplicationContext reactContext, NativeModuleRegistry.Builder nativeRegistryBuilder) {
private void addNativeModules(ReactApplicationContext reactContext, NativeModuleRegistryBuilder nativeRegistryBuilder) {
for (int i = 0; i < reactPackages.size(); i++) {
ReactPackage reactPackage = reactPackages.get(i);
for (NativeModule nativeModule : reactPackage.createNativeModules(reactContext)) {
nativeRegistryBuilder.add(nativeModule);
nativeRegistryBuilder.addNativeModule(nativeModule);
}
}
}
}
}
2 changes: 1 addition & 1 deletion ios/Workers/WorkerManager.m
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#import "WorkerManager.h"
#import "WorkerSelfManager.h"
#include <stdlib.h>
#import "RCTBridge.h"
#import "React/RCTBridge.h"
#import "RCTBridge+Private.h"
#import "RCTEventDispatcher.h"
#import "RCTBundleURLProvider.h"
Expand Down
2 changes: 1 addition & 1 deletion ios/Workers/WorkerSelfManager.m
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#import "WorkerSelfManager.h"
#include <stdlib.h>
#import "RCTBridge.h"
#import "React/RCTBridge.h"
#import "RCTBridge+Private.h"
#import "RCTEventDispatcher.h"

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-workers",
"version": "0.3.1",
"version": "0.3.2",
"description": "react native web workers",
"main": "index.js",
"scripts": {
Expand Down