Add support for multiple host domains. #249
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pantierra
force-pushed
the
feature/support-several-domains
branch
from
805f063 to
d3713f0
Compare
ciaransweet
approved these changes
Sep 2, 2025
Contributor
ciaransweet
left a comment
ciaransweet
left a comment
There was a problem hiding this comment.
LGTM, the tests are real nice! - Looks like some teardown failures in the pipeline though @pantierra
pantierra
force-pushed
the
feature/support-several-domains
branch
2 times, most recently
from
c0d0cef to
d69612b
Compare
ciaransweet
approved these changes
Sep 3, 2025
pantierra
force-pushed
the
feature/support-several-domains
branch
from
d69612b to
e0178da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to run eoAPI on multiple domains as suggested in #248