Add optional auth tooling #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@vincentsarago did a bit of a refactor, it's feeling a bit cleaner. Going to try to put together some tests before marking this as ready. |
alukach
commented
Aug 19, 2024
| boolean) | ||
| bool "$value" | ||
| ;; | ||
| integer | number | object) |
Member
Author
There was a problem hiding this comment.
Customization added in radiantearth/stac-browser#461
… into feature/add-auth
Member
Author
|
@vincentsarago Hope I didn't steal your thunder, but I gave the breakout a try in aa30f7d. Feel free to suggest changes. |
alukach
force-pushed
the
feature/add-auth
branch
from
58c5f59 to
4996c8b
Compare
vincentsarago
requested changes
Aug 20, 2024
Member
vincentsarago
left a comment
vincentsarago
left a comment
There was a problem hiding this comment.
few changes I think we should do but the overall looks great
| root_path=settings.root_path, | ||
| lifespan=lifespan, | ||
| swagger_ui_init_oauth={ | ||
| "clientId": auth_settings.client_id, |
Member
There was a problem hiding this comment.
when client_id is set to "" does Swagger understand that its unavailable?
Member
Author
There was a problem hiding this comment.
The clientId property populates the value on the auth form's text input (docs). As such, an empty string is equivalent to null
vincentsarago
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
How I did it
How you can test it
Related Issues