-
Notifications
You must be signed in to change notification settings - Fork 6
feat(titiler-pgstac-api): add titiler-pgstac endpoint #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0dc16b9 to
fac2b92
Compare
|
I tried to deploy, and unfortunately the size of the unzipped package is too large to be used for a lambda function (I think it's because titiler.pgstac has many dependencies), so I have to use a Dockerfile instead, just like it's done here or here (any thoughts @vincentsarago ? Thanks !) Just pushed the Dockerfile, that works, but need to change the CDK code and test it, so I changed the title of this PR to |
|
@emileten, Dockerimage in Lambda should only be use if absolutely no choice (because it's much slower, at least for dynamic tiling)
I've deployed titiler.pgstac in lambda before so I doubt this is the case! Oh, I misread the comments at first. Yes using simple as you can see in the dockerfile we do https://github.com/developmentseed/cdk-pgstac/pull/42/files#diff-6b803bce2d18a876f97ed5ee61d6137408b36add96327274f990ff18d81430a4R11-R16 which is 👍 |
|
Great that matches with my understanding ! Thank you! |
* added a new service deploying a titiler-pgstac service with access to the pgstac database, and exposing its API change requirements and add Dockerfile switch to docker build based lambda code to make the package lighter
8f6faf4 to
5617b22
Compare
|
Any chance someone takes a look in the following days? @sharkinsspatial ? or anyone else 😄 |
vincentsarago
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but I'm not familiar enough with cdk-pgstac that you might want to wait for @alukach or @sharkinsspatial approval 🤷
alukach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strongly recommended changes:
git rm lib/titiler-pgstac-api/runtime/src/.env- Don't write the pgstac secret values to stdout.
Otherwise, I think this looks good. Left some other comments but those are mostly focused on upping my understanding on how this work.
avoid printing secret and simplify environment update Co-authored-by: Anthony Lukach <[email protected]>
bump python version Co-authored-by: Anthony Lukach <[email protected]>
simplify Dockerfile Co-authored-by: Anthony Lukach <[email protected]>
|
@alukach I added most of your suggestions -- good to merge ? |
alukach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emileten Realized I was still marked as "requested changes". I'm good with merging if you are.
alukach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@emileten Realized I was still marked as "requested changes". I'm good with merging if you are.
|
Thanks @alukach ! Should be -- just wanted to check the last comment I haven't read above tomorrow. |
# [4.2.0](v4.1.0...v4.2.0) (2023-06-09) ### Features * **titiler-pgstac-api:** add titiler-pgstac endpoint ([#42](#42)) ([a02acef](a02acef))
Solves #40 by adding a 'titiler-pgstac' construct, which mirrors the STAC API construct : I essentially
app.pycode and simply wrotefrom titiler.pgstac.main import appin thehandler.pyconfig.py(titiler.pgstac.mainrequires the postgres credentials to be set as environment variables)