Error thrown with Preact8 #10
Merged
+106
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occurs when `CSSTransitionGroup` is provided with `children` containing `null`
Owner
|
Wow, this is a flawless PR. Thanks dude. |
developit
approved these changes
Apr 12, 2017
Contributor
Author
|
You're welcome! |
Contributor
Author
|
@developit Any chance for the fix to be released on npm? |
Owner
|
Yup! |
Owner
|
Released as 1.2.0 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing
preact@8within our existing code base, we encountered the following error :As far as I understand,
preact@8components might receive an array containingnullvalues (e.g.[null]) aschildrenproperty while it never happened in the previous versions.This PR attempts to fix the compatibility with
preact@8:npm testorPREACT_VERSION=7.2.0 npm testbut fails withPREACT_VERSION=8.1.0 npm testnullentries that might be received in thechildrenprop. Please tell me if it's a good approach or not.7.2.1and8.1.0totravis.ymlin the last commit, so the test is actually ran on the appropriate versions.