Skip to content

Issue #3 Name Render #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Issue #3 Name Render #81

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e6787dc
Issue #3 Revenue Fix
Krishvora Nov 24, 2022
737e11f
Issue #1 Name Render
Krishvora Nov 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/ui.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import {fetchCompanies} from "./api";
import { fetchCompanies } from "./api";
import {
ACCOUNT_EXECUTIVE_FIELD_NAME,
COMPANIES_TABLE_HEADERS,
COMPANY_NAME_FIELD_NAME,
CREATED_AT_FIELD_NAME,
REVENUE_YTD_FIELD_NAME,
STATUS_FIELD_NAME
STATUS_FIELD_NAME,
} from "./constants";

export const makeTable = async () => {
Expand All @@ -20,13 +20,13 @@ export const makeTable = async () => {
companiesToDisplay.push(COMPANIES_TABLE_HEADERS);

// Here we simply rearrange company fields in the order in which we want to display them in UI
companies.map(company => {
companies.map((company) => {
const row = [];
row.push(
company[COMPANY_NAME_FIELD_NAME],
company[STATUS_FIELD_NAME],
company[CREATED_AT_FIELD_NAME],
company[REVENUE_YTD_FIELD_NAME],
company[REVENUE_YTD_FIELD_NAME].toLocaleString("en", { maximumSignificantDigits: 3 }),
company[ACCOUNT_EXECUTIVE_FIELD_NAME]
);
companiesToDisplay.push(row);
Expand All @@ -36,12 +36,12 @@ export const makeTable = async () => {
const table = document.createElement("table");
document.body.appendChild(table); // Drew the main table node on the document

companiesToDisplay.forEach(row => {
companiesToDisplay.forEach((row) => {
const tr = table.insertRow(); //Create a new row

row.forEach(column => {
row.forEach((column) => {
const td = tr.insertCell();
td.innerText = column; // Take string from placeholder variable and append it to <tr> node
});
});
};
};