Skip to content

Fix all issues and add more features #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix all issues and add more features #103

wants to merge 5 commits into from

Conversation

paty-oliveira
Copy link

  • Fix issue about the company name not appearing
  • Transform created_at column into readable format
  • Transform revenue_ytd column into readable format
  • Make table looks prettier

sbmsr
sbmsr reviewed Aug 9, 2023
View reviewed changes
src/constants.js
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job formatting the COMPANIES_TABLE_HEADERS array to have each item on a new line. It improves readability. However, it seems that the COMPANY_NAME_FIELD_NAME constant was changed from company_name to name. Please confirm if this was intentional.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional! Based on my understanding, it is the fix for the undefined company name. It is based on db.json fields, where the name field is the company name not company_name. However, let me know if I'm not thinking correctly 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbmsr sbmsr sbmsr left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paty-oliveira @sbmsr