Fix git-lfs unnecessary hook installation

[yaegashi]

Fix an issue where git lfs install was running unnecessarily in repositories without LFS files, causing hooks to be installed when they shouldn't be.

Changes:

• Update src/git-lfs/install.sh to properly check for empty git lfs ls-files output
• Add comprehensive test (test/git-lfs/noLfsFiles.sh) to verify hooks are not installed when no LFS files are present
• Update test scenarios to include the new test case

The fix changes the condition from checking command exit status to checking if the output is empty, preventing unnecessary hook installation in non-LFS repos.

Related issues/PRs:

• git-lfs not actually running git lfs install #1379
• Fix git-lfs not actually running git lfs install #1381

The changes above introduced new problems in the following scenario:

• Starting a dev container from the default universal image with the git-lfs feature

• Add devcontainer.json without the git-lfs feature and rebuild the container

• Encounter the following warnings/errors when trying to use git checkout, commit, or push:

  $ git push origin new-branch
  
  This repository is configured for Git LFS but 'git-lfs' was not found on your path. If you no longer wish to use Git LFS, remove this hook by deleting the 'pre-push' file in the hooks directory (set by 'core.hookspath'; usually '.git/hooks').
   
  error: failed to push some refs to 'https://github.com/yaegashi/foo'

[Copilot]

Pull Request Overview

This PR fixes an issue where Git LFS hooks were being installed unnecessarily in repositories without LFS files. The fix changes the detection logic from checking command exit status to verifying if the output is empty, preventing hook installation in non-LFS repositories.

• Modified the LFS detection logic in the install script to check for empty output instead of command exit status
• Added a comprehensive test case to verify hooks are not installed when no LFS files are present
• Updated test scenarios to include the new test case for repositories without LFS files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
src/git-lfs/install.sh	Updated LFS detection logic to check for empty output and separate error handling
test/git-lfs/noLfsFiles.sh	Added new test to verify no hooks are installed in repositories without LFS files
test/git-lfs/scenarios.json	Added test scenario configuration for repositories without LFS files

Comments suppressed due to low confidence (1)

test/git-lfs/noLfsFiles.sh:22

• This test redirects stderr to /dev/null which may hide important error messages that could help diagnose test failures. Consider capturing and checking the error output separately or allowing it to be visible during test execution.

check "git lfs ls-files returns empty output" test -z "$(git lfs ls-files 2>/dev/null)"