-
Notifications
You must be signed in to change notification settings - Fork 350
feat: add Starship feature to collection index #605
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
| - name: Starship | ||
| maintainer: Tobias Chavarria | ||
| contact: https://github.com/tobiaschc/devcontainer-features/issues | ||
| repository: https://github.com/tobiaschc/devcontainer-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @tobiaschc
Thank you for the contribution. Would you kindly change the repository url to the feature base path https://github.com/tobiaschc/devcontainer-features/tree/main/src/starship
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Kaniska244,
Thanks for the review. I just updated the url.
Kaniska244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks fine. To be further reviewed by maintainers
| maintainer: Tobias Chavarria | ||
| contact: https://github.com/tobiaschc/devcontainer-features/issues | ||
| repository: https://github.com/tobiaschc/devcontainer-features | ||
| ociReference: ghcr.io/tobiaschc/devcontainer-features |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! can you update the registry so it is public? Also, the links need to point the the base registry, not the feature! Thanks ![]()
What type of PR is this?
Related Issues
Description
Add a new dev container feature to the collection. Although there are already features for Starship, mine provides an option to target a
starship.tomlfile in a repository (a dotfiles one for example) or reference one locally. It also offers the opportunity to install a specified Nerd Font.Check: https://github.com/tobiaschc/devcontainer-features
Collection checklist
If your PR contributes a new collection, please utilize this checklist: