-
Notifications
You must be signed in to change notification settings - Fork 353
Add mattmazzola/devcontainers to collections-index.yml #569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mattmazzola/devcontainers to collections-index.yml #569
Conversation
|
Hello @mattmazzola , Thank you for the contribution. One small question, does this template offer anything different from this one already listed in the devcontainers templates index. |
I would say yes, it comes with a lot of other features and extensions which are mostly personal preferences. For example, mine uses the UV container feature for install, while the one you liked uses RUN commands in Dockerfile to install uv. I think if the intention is to keep the index only referring to minimal set of devcontainers then perhaps this PR isn't what I thought and can be closed. I wanted a way to make the devcontainers I was developing show in VScode for convenience and for other collaborators to use and test. Based on the documentation I found, adding my templates to the index seemed liked the only way. Although I anticipate that this process could contribute to noise if everyone adds their personal containers to the index and it causes the index to be overwhelming and perhaps less usable. However, I assumed this is unlikely since very few people are writing container templates I saw what looked like other personal devcontainer repositories listed in the index and thought, Ok, perhaps this practice is allowed and expected, and so I submitted mine as well From what I understand, once your repo is added. You can add other templates and they will implicitly show up |
Kaniska244
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change is fine. To be further reviewed by maintainers
AlvaroRausell
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your addition!
What type of PR is this?
Related Issues
Description
Collection checklist
If your PR contributes a new collection, please utilize this checklist: