Fix contracts 0.8.9 build for test:fix on win platform #699
Conversation
|
CONTRIBUTING.md
Outdated
|
|
||
| Heads up: we use pnpm instead of yarn or npm. It might be new for you but I promise it's worth the hassle - it's really | ||
| good at making big monorepos deterministic. Please ensure that you are running pnpm version 7. | ||
| Heads up: we use pnpm instead of yarn or npm. It might be Q new for you but I promise it's worth the hassle - it's |
contracts/v0.6.4/LibraryPerson.sol
Outdated
| @@ -0,0 +1,48 @@ | |||
| pragma solidity ^0.6.4; | |||
There was a problem hiding this comment.
can we move these contracts to a separate PR? lets just fix windows development in this one
There was a problem hiding this comment.
Absolutely, sorry I didn't realize it had taken multiple commits.
There was a problem hiding this comment.
Will you find time to fix it or should I step in? :)
There was a problem hiding this comment.
Absolutely, I just removed the files, sorry again, I was convinced I was committing to my fork.
The PR idea was just for the "compile-contract.ts" file.
Contributing.md are my personal notes, do we keep them or do you prefer to remove them?
Thanks
This reverts commit b1c209b.
|
Awesome, thank you! |
2 participants
Hi guys,
during set up for Development i try to run "test:fix" on window and get error about "contracts not found" for 0.8.9.
Fix is add base path to solc contract compile process.