Skip to content

Show effective short apr in preview #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Show effective short apr in preview #1165

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0a3834a
show short apr after open
jackburrus Jun 11, 2024
507baf9
adds short apr after open
jackburrus Jun 11, 2024
a1709a8
Merge branch 'main' into jack-fixes-effective-short-apr
jackburrus Jun 11, 2024
6e41eb5
Rename label
jackburrus Jun 11, 2024
bf33ce7
updates per comments
jackburrus Jun 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 32 additions & 0 deletions apps/hyperdrive-trading/src/ui/hyperdrive/shorts/OpenShortPreview/OpenShortPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,8 @@ import { LabelValue } from "src/ui/base/components/LabelValue";
import { formatBalance } from "src/ui/base/formatting/formatBalance";
import { formatDate } from "src/ui/base/formatting/formatDate";
import { useFixedRate } from "src/ui/hyperdrive/longs/hooks/useFixedRate";
import { useShortRate } from "src/ui/hyperdrive/shorts/hooks/useShortRate";
import { useYieldSourceRate } from "src/ui/vaults/useYieldSourceRate";
interface OpenShortPreviewProps {
hyperdrive: HyperdriveConfig;
tokenIn: TokenConfig<any>;
Expand All @@ -40,6 +42,16 @@ export function OpenShortPreview({
});
const { fixedApr } = useFixedRate(hyperdrive.address);
const termLengthMS = Number(hyperdrive.poolConfig.positionDuration * 1000n);
const { vaultRate } = useYieldSourceRate({
hyperdriveAddress: hyperdrive.address,
});
const { shortApr, shortRateStatus } = useShortRate({
bondAmount: shortSize,
hyperdriveAddress: hyperdrive.address,
timestamp: BigInt(Math.floor(Date.now() / 1000)),
variableApy: vaultRate?.vaultRate,
});

return (
<div className="flex flex-col gap-3">
<LabelValue
Expand Down Expand Up @@ -101,6 +113,26 @@ export function OpenShortPreview({
)
}
/>
<LabelValue
label="Net Short Rate"
value={
shortRateStatus === "loading" ? (
<Skeleton width={100} />
) : (
<span
className={classNames(
"daisy-tooltip daisy-tooltip-top daisy-tooltip-left cursor-help before:border",
{
"border-b border-dashed border-current": spotRateAfterOpen,
},
)}
data-tip="The annualized return on shorts assuming the current yield source rate stays the same for one year"
>
{shortApr ? `${shortApr.formatted}% APR` : "-"}
</span>
)
}
/>
<div className="flex flex-col gap-3">
<h6 className="font-medium">Market Impact</h6>
<LabelValue
Expand Down