Skip to content

Conversation

@sdimitro
Copy link
Contributor

@sdimitro sdimitro commented Aug 1, 2022

Make all the Github CI checks to pass again.

Most issues fixed are related to code formatting and linting.

Besides those, the rest of the regression failures have to do
with drgn returning duplicate stack frame entries for inlined
functions. We don't attempt to do anything about those
failures for now other than recreating our reference/expected
command ouput for the stacks command regression tests
to match what drgn returns (tackling this could be tricky,
especially in situations where a stacktrace involves recursion).

Finally we update the OS of the CI runs to Ubuntu 20.04 and
"raise" our officially minimal supported python version to
python 3.8. Older versions like 3.6 and 3.7 should still work
but maintaining CI runs of them can get annoying over time
as pylint of 3.8 may raise issues not raised in pylint of
python 3.7 and vice versa.

@sdimitro sdimitro requested review from ahrens and prakashsurya and removed request for ahrens August 1, 2022 16:49
@sdimitro sdimitro force-pushed the fix-regressions-0 branch from 273ae6c to a190dc8 Compare August 1, 2022 16:59
@sdimitro sdimitro requested a review from ahrens August 1, 2022 17:00
@sdimitro sdimitro force-pushed the fix-regressions-0 branch from a190dc8 to 9ceeacf Compare August 1, 2022 17:17
Copy link
Contributor

@prakashsurya prakashsurya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you'll need to land this directly to 6.0/stage now.

@sdimitro sdimitro changed the base branch from master to 6.0/stage August 1, 2022 17:58
@sdimitro sdimitro force-pushed the fix-regressions-0 branch from 9ceeacf to 89d318d Compare August 1, 2022 18:16
@sdimitro sdimitro merged commit 5a63d1a into delphix:6.0/stage Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants