Fix Latest Regressions #254
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drgn recently dropped all semantics of == for drgn.Type objects in the following commit as there are multiple reasonable ways to define type equality depending on the use case: osandov/drgn@7d7aa7b We already have our own definition within SDB were we pretty much match types by name [see comment sdb.target.type_equals()]. This commit updates leftover instances of == for types within SDB.
sdimitro
force-pushed
the
update_drgn_type_equality
branch
from
a0a4378 to
df405cd
Compare
sdimitro
changed the title
prakashsurya
approved these changes
Feb 3, 2021
ahrens
approved these changes
Feb 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix regressions introduced by drgn's updated type equality
drgn recently dropped all semantics of == for drgn.Type objects
in the following commit as there are multiple reasonable ways
to define type equality depending on the use case:
osandov/drgn@7d7aa7b
We already have our own definition within SDB were we pretty
much match types by name [see comment sdb.target.type_equals()].
This commit updates leftover instances of == for types within SDB.
Testing
Automated tests/regressions don't fail anymore