Fix Latest pylint Errors #240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1: Fix latest pylint errors
Pylint started being more strict about the use of Python's
raise-from syntax explained here:
https://www.python.org/dev/peps/pep-3134/
The main idea is to provide a proper traceback whenever an
exception is caught and rethrown. Specifically in our case
though the use of raise-from shouldn't make any difference
for us because SDB is a REPL and prints the error messages
of our sdb-defined exceptions (which are basically faulty
exits of SDB commands).
Commit 2: Undo commit 9cd5599
The latest version of pylint has fixed the false positives
that we worked around on that commit.
Commit 3: update drgn type instantiation routines
drgn changed the way what you instantiate a type object, so we need to
update type_canonicalize().