Skip to content

Conversation

@sravyamks
Copy link
Contributor

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build was run locally and any changes were pushed
  • Lint has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #229 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #229   +/-   ##
=======================================
  Coverage   87.29%   87.29%           
=======================================
  Files          60       60           
  Lines        2456     2456           
=======================================
  Hits         2144     2144           
  Misses        312      312           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b125de...99824c7. Read the comment docs.

@sdimitro
Copy link
Contributor

sdimitro commented Jun 5, 2020

@sravyamks can you rebase your branch and have the introduction of the new copyright file as a single commit? Once that is done I can find us a second reviewer and I can go ahead and merge this

@ahrens
Copy link
Contributor

ahrens commented Jun 5, 2020

@sdimitro I think you can do the rebase & single commit by using the "squash and merge" button when integrating (assuming there are no merge conflicts).

@sdimitro
Copy link
Contributor

sdimitro commented Jun 5, 2020

@ahrens yeah that definitely works. Thanks Matt!

@sdimitro sdimitro merged commit d3aded5 into delphix:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants