Use "delphix/actions" for shfmt #223
Conversation
|
This is depends on: delphix/actions#3 and delphix/actions#4 |
| - uses: actions/checkout@v2 | ||
| - run: ./.github/scripts/install-shfmt.sh | ||
| - run: /usr/local/bin/shfmt -d . | ||
| - uses: delphix/actions/shfmt@master |
There was a problem hiding this comment.
We don't also run shellcheck for sdb?
There was a problem hiding this comment.
I don't see it used anywhere in this repository, do you? Did I overlook something?
There was a problem hiding this comment.
Sorry, I meant that as a generic question. @sdimitro Is there an explicit reason we aren't running shellcheck? Should we add it?
There was a problem hiding this comment.
No explicit reason - I just only knew about shfmt at the time when I made that change :-)
There was a problem hiding this comment.
Okay, we can perhaps consider adding it in a later commit.
sdimitro
left a comment
sdimitro
left a comment
There was a problem hiding this comment.
ShipIt pending test doesn't fail once the other commits make it in.
prakashsurya
force-pushed
the
use-delphix-actions
branch
from
502b654 to
a84b015
Compare
3 participants
No description provided.