Fix nightly yapf warnings + minor refactoring

sdb/commands/internal/table.py

@@ -35,11 +35,11 @@ class Table:
     #
     # pylint: disable=bad-continuation
     def __init__(
-        self,
-        fields: List[str],
-        rjustfields: Optional[Set[str]] = None,
-        formatters: Optional[Dict[str, Callable[[Any], str]]] = None
-    ) -> None:
+            self,
+            fields: List[str],
+            rjustfields: Optional[Set[str]] = None,
+            formatters: Optional[Dict[str, Callable[[Any],
+                                                    str]]] = None) -> None:
         self.fields = fields
 
         if rjustfields is None:
@@ -93,13 +93,11 @@ def print_(self,
                 continue
 
             line_fields = []
-            for fid in range(len(self.fields)):
-                if self.fields[fid] in self.rjustfields:
+            for fid, field in enumerate(self.fields):
+                if field in self.rjustfields:
                     line_fields.append(
-                        f"{row_values[fid]:>{self.maxfieldlen[self.fields[fid]]}}"
-                    )
+                        f"{row_values[fid]:>{self.maxfieldlen[field]}}")
                 else:
                     line_fields.append(
-                        f"{row_values[fid]:<{self.maxfieldlen[self.fields[fid]]}}"
-                    )
+                        f"{row_values[fid]:<{self.maxfieldlen[field]}}")
             print(delimeter.join(line_fields))

sdb/commands/linux/per_cpu.py

@@ -96,6 +96,6 @@ class LxPerCpuCounterSum(sdb.SingleInputCommand):
     def _call_one(self, obj: drgn.Object) -> Iterable[drgn.Object]:
         try:
             sum_ = drgn_percpu.percpu_counter_sum(obj)
-        except AttributeError as err:
+        except AttributeError:
             raise sdb.CommandError(self.name, "input is not a percpu_counter")
         yield drgn.Object(sdb.get_prog(), type="s64", value=sum_)

sdb/commands/linux/slabs.py

@@ -110,8 +110,8 @@ def no_input(self) -> Iterable[drgn.Object]:
             yield from sorted(
                 self.__no_input_iterator(),
                 key=Slabs.FIELDS[self.args.s],
-                reverse=(
-                    self.args.s not in Slabs.DEFAULT_INCREASING_ORDER_FIELDS))
+                reverse=(self.args.s
+                         not in Slabs.DEFAULT_INCREASING_ORDER_FIELDS))
         else:
             yield from self.__no_input_iterator()
 

sdb/commands/spl/spl_kmem_caches.py

@@ -100,8 +100,8 @@ def no_input(self) -> Iterable[drgn.Object]:
             yield from sorted(
                 kmem.for_each_spl_kmem_cache(),
                 key=SplKmemCaches.FIELDS[self.args.s],
-                reverse=(self.args.s not in
-                         SplKmemCaches.DEFAULT_INCREASING_ORDER_FIELDS))
+                reverse=(self.args.s
+                         not in SplKmemCaches.DEFAULT_INCREASING_ORDER_FIELDS))
         else:
             yield from kmem.for_each_spl_kmem_cache()
 

sdb/commands/zfs/internal/__init__.py

@@ -17,7 +17,6 @@
 # pylint: disable=missing-docstring
 
 import os
-from typing import List
 
 import drgn
 import sdb

sdb/commands/zfs/metaslab.py

@@ -192,6 +192,6 @@ def from_vdev(self, vdev: drgn.Object) -> Iterable[drgn.Object]:
                             i, int(vdev.vdev_ms_count), int(vdev.vdev_id)))
                 yield vdev.vdev_ms[i]
         else:
-            for i in range(0, int(vdev.vdev_ms_count)):
+            for i in range(int(vdev.vdev_ms_count)):
                 msp = vdev.vdev_ms[i]
                 yield msp

sdb/commands/zfs/vdev.py

@@ -130,6 +130,6 @@ def from_vdev(self, vdev: drgn.Object) -> Iterable[drgn.Object]:
                 self.name, "when providing a vdev, "
                 "specific child vdevs can not be requested")
         yield vdev
-        for cid in range(0, int(vdev.vdev_children)):
+        for cid in range(int(vdev.vdev_children)):
             cvd = vdev.vdev_child[cid]
             yield from self.from_vdev(cvd)

sdb/pipeline.py

@@ -1,4 +1,4 @@
-#o
+#
 # Copyright 2019 Delphix
 #
 # Licensed under the Apache License, Version 2.0 (the "License");

setup.py

@@ -1,6 +1,6 @@
 #!/usr/bin/env python3
 
-from setuptools import setup, find_packages
+from setuptools import setup
 
 setup(
     name='sdb',