dbuf command filtering does not work in all invocations #184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dbuf command can select dbufs that match certain parameters (e.g. '-l 1' for level-1 dbufs). This works when `dbuf` is the first command in the pipeline, and when it is used as a locator with a dnode_t* as input. But it doesn't work in other circumstances, for example when it's being used only as a pretty-printer (with the list of dbufs piped in), or when it's used in the middle of a pipeline. This change adds the filter calls to this use cases, and adds corresponding test cases
sdimitro
pushed a commit
that referenced
this pull request
Mar 27, 2020
The dbuf command can select dbufs that match certain parameters (e.g. '-l 1' for level-1 dbufs). This works when `dbuf` is the first command in the pipeline, and when it is used as a locator with a dnode_t* as input. But it doesn't work in other circumstances, for example when it's being used only as a pretty-printer (with the list of dbufs piped in), or when it's used in the middle of a pipeline. This change adds the filter calls to this use cases, and adds corresponding test cases
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dbuf command can select dbufs that match certain parameters (e.g.
'-l 1' for level-1 dbufs). This works when
dbufis the first commandin the pipeline, and when it is used as a locator with a dnode_t* as
input. But it doesn't work in other circumstances, for example
when it's being used only as a pretty-printer (with the list of dbufs
piped in), or when it's used in the middle of a pipeline.
This change adds the filter calls to this use cases, and adds
corresponding test cases
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information