MYSQL-7 : Password Values not redacted in the shell logs , MYSQL-18 Environment refresh and discovery operation shows passwords/sensitive data

[vinaybyrappa]

Background :-
Passwords values not redacted in the shell logs , Environment refresh and discovery operation shows passwords/sensitive data

Solution
All the passwords are masked in the shell and in the python files all the successfull messages which contains information of password is removed
VDB title was showing password and other db credentials, have changed that to show only db name

[gmanhas23]

Looks good to me... Just the one commented line that we need to remove

[batrankit]

Comment 1:-
Some of these files have the copyright statements and some do not.

We need to make it consistent. Also where ever copyright is present, that has not been updated.

Comment 2:-
Can you please check if the password is still being seen at the below places from the logs:-
delphix_mysql_debug.log:[2023-01-16T03:54:21][DEBUG][restore_stage_bi.sh][]:[Creation Results: { "conn": "-uroot --host=localhost -p***** "pass": "'?I>;bjcZ[2023-01-16T03:54:21][DEBUG][restore_stage_bi.sh][]:[Creating Staging Directories on NFS Mounted Path from Delphix ...]

delphix_mysql_debug.log:[2023-01-16T03:54:21][DEBUG][restore_stage_bi.sh][]:[Return message:mysql: [Warning] Using a password on the command line interface can be insecure.]
delphix_mysql_debug.log:SOURCEPASS=Pass@123
delphix_mysql_debug.log:STAGINGPASS=

[2023-01-16T04:34:26][DEBUG][restore_stage.sh][]:[Creation Results: {
"conn": "-uroot --host=localhost -p",
"pass": "'Func8=>sTqhU'",
"string": "-uroot --host=localhost -p'Func8=>sTqhU' --protocol=TCP --port=3308"
}]

[gmanhas23]

Line 477 ( now 474) in restore_stage_bi.sh is logging SOURCEPASS in debug logs