Add new zfs dbg package in each variant #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prakashsurya
approved these changes
Apr 29, 2020
sebroy
approved these changes
Apr 29, 2020
pzakha
approved these changes
Apr 29, 2020
Contributor
pzakha
left a comment
pzakha
left a comment
There was a problem hiding this comment.
LGTM, have you tried spinning up the appliances created with those changes?
Contributor
Author
|
@pzakha Yes I did so I can test again the other PR -> https://github.com/delphix/zfs/pull/154 My instances are still up: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of: https://github.com/delphix/zfs/pull/154
Retested the above PR with the images created from the links below.
= Automated testing
Linux-pkg kernel run with custom ZFS and delphix-kernel:
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/linux-pkg-build/job/master/job/kernel/job/pre-push/190/
ESX appliance-build (used S3 link of above run for kernel packages):
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/3357/
AWS appliance-build (used S3 link of above run for kernel packages):
http://selfservice.jenkins.delphix.com/job/devops-gate/job/master/job/appliance-build-orchestrator-pre-push/3356/