Skip to content

Conversation

@johannesduesing
Copy link
Contributor

Reason for this PR
The interface of the instance registry has been changed lately. The reason for this was to better support the requirements of the Delphi-Management state management. The relevant change is:

  • The attributes linksTo: List[InstanceLink] and linksFrom: List[InstanceLink] have been added to the Instance class
    This PR adapts the WebApp to this change.

Changes

  • Added file InstanceLink.scala containing the JSON support
  • Added new attributes to Instance

Links are now attributes of instances (linksTo and linksFrom)
@codecov-io
Copy link

Codecov Report

Merging #24 into develop will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           develop   #24   +/-   ##
=====================================
  Coverage        0%    0%           
=====================================
  Files           10    11    +1     
  Lines          234   248   +14     
  Branches        23    28    +5     
=====================================
- Misses         234   248   +14
Impacted Files Coverage Δ
app/utils/Configuration.scala 0% <ø> (ø) ⬆️
app/utils/instancemanagement/InstanceLink.scala 0% <0%> (ø)
...pp/utils/instancemanagement/InstanceRegistry.scala 0% <0%> (ø) ⬆️
app/utils/instancemanagement/Instance.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a5b352...c53ac90. Read the comment docs.

@bhermann bhermann merged commit 8657863 into develop Nov 24, 2018
@ghost ghost removed the review label Nov 24, 2018
@bhermann bhermann deleted the feature/linksAsAttributes branch November 24, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants