-
Notifications
You must be signed in to change notification settings - Fork 5
Hotfix/parsing error #95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ent. added hot reloading functionality for state change events. fixed parse error in frontend
Codecov Report
@@ Coverage Diff @@
## develop #95 +/- ##
==========================================
+ Coverage 4.65% 4.69% +0.04%
==========================================
Files 11 11
Lines 215 213 -2
Branches 9 15 +6
==========================================
Hits 10 10
+ Misses 205 203 -2
Continue to review full report at Codecov.
|
fixed incorrect port number in readme
johannesduesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working just fine. I found that deleting a paused instance is possible from the frontend (@ishwaryaPaderborn is this desired behavior?), but docker actually issues an error that paused instances cannot be deleted. I will change the registry accordingly, so only stopped instances can be deleted 👍
|
@janniclas Below are the few issues I found :
@johannesduesing I remember discussing this case with the backend team, it was told that only a 'Stopped' instance cannot be deleted and in all other cases it can be deleted. But we can make the changes in the frontend to restrict deleteing even when an instance is 'Paused'. |
This pull request addresses all errors left open in #89 .
The main points that were fix are
@johannesduesing & @ishwaryaPaderborn , since you two investigated the last pull request and reported the open errors I would like to ask you two again to verify if this pull requests successfully resolves them.