Skip to content

Conversation

@janniclas
Copy link
Contributor

@janniclas janniclas commented Jan 17, 2019

This pull request addresses all errors left open in #89 .
The main points that were fix are

@johannesduesing & @ishwaryaPaderborn , since you two investigated the last pull request and reported the open errors I would like to ask you two again to verify if this pull requests successfully resolves them.

@codecov-io
Copy link

codecov-io commented Jan 17, 2019

Codecov Report

Merging #95 into develop will increase coverage by 0.04%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #95      +/-   ##
==========================================
+ Coverage     4.65%   4.69%   +0.04%     
==========================================
  Files           11      11              
  Lines          215     213       -2     
  Branches         9      15       +6     
==========================================
  Hits            10      10              
+ Misses         205     203       -2
Impacted Files Coverage Δ
app/controllers/InstanceRegistryController.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a29a31...66a9247. Read the comment docs.

Copy link
Contributor

@johannesduesing johannesduesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working just fine. I found that deleting a paused instance is possible from the frontend (@ishwaryaPaderborn is this desired behavior?), but docker actually issues an error that paused instances cannot be deleted. I will change the registry accordingly, so only stopped instances can be deleted 👍

@ishwaryamamidi
Copy link
Contributor

@janniclas Below are the few issues I found :

  1. When an Instance is 'Running' and try to 'Resume' it throws a 400 error.
  2. When an Instance is 'Paused' and try to 'Resume' it the state changes to 'Running'. I think in this case the state should be updated to 'Resumed'.

@johannesduesing I remember discussing this case with the backend team, it was told that only a 'Stopped' instance cannot be deleted and in all other cases it can be deleted. But we can make the changes in the frontend to restrict deleteing even when an instance is 'Paused'.

@janniclas janniclas merged commit 08fdb6e into develop Jan 20, 2019
@ghost ghost removed the review label Jan 20, 2019
@janniclas janniclas deleted the hotfix/parsingError branch January 20, 2019 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants