Updates Client Dependencies #156
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhermann
approved these changes
Dec 23, 2019
Member
bhermann
left a comment
bhermann
left a comment
There was a problem hiding this comment.
I made a check. Looking good!
Thank you very much and happy holidays!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests contains an update of the clients dependency libraries to support the newer angular 8 version.
The automated tests have been executed, as well as the build processes. When running the application with "ng serve" no error occurs either, but the update has not been through an integration test, since I currently have no setup running scala. Thus I couldn't test the usage with the management backend server and the instance-registry.
Also I sneaked in a change to the .travis.yml in which I separated the build process in multiple stages, one for each language (scala and javascript). This provides the possibility for a more detailed control of the build environment.