-
Notifications
You must be signed in to change notification settings - Fork 5
Feature/drag and drop edges #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…rop of edges as described in #85
…e component class
…t node. added image for edge drag point
…ure/dragAndDropEdges
cancling subscriptions on destroy
… where the system's state is corupted after switching views and edditing instances
Codecov Report
@@ Coverage Diff @@
## develop #115 +/- ##
==========================================
- Coverage 4.52% 4.34% -0.18%
==========================================
Files 12 12
Lines 221 230 +9
Branches 17 16 -1
==========================================
Hits 10 10
- Misses 211 220 +9
Continue to review full report at Codecov.
|
johannesduesing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As requested i did a functional test on this code, which already worked pretty well when i tested it with a rather big setup on the deployment server on Thursday. This time i used a smaller setup with 2 APIs and one WebApp.
It's working fine for me, re-assigning, coloring and hiding components and edges is working as expected. The only issue i can see is that you are currently able to re-assign a component to the same instance that it is already using, which is actually triggering a re-assignment call to the registry. I would expect to either hide the currently used dependency or just give the user a message that re-assignment is not needed because the desired dependency is already established.
Since i remember talking with @janniclas about this i'm not sure if that's intended behaviour for this PR, so i will still approve it in the current state.
This pull request contains the functionality to drag and drop edges from existing components to reconnect them to another component.
Also multiple bug fixes and stability improvements of the graph module have been implemented
closes: #108 and #85