Added table expand feature to display docker ID and labels. #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
janniclas
reviewed
Jan 23, 2019
Codecov Report
@@ Coverage Diff @@
## develop #104 +/- ##
=======================================
Coverage 4.69% 4.69%
=======================================
Files 11 11
Lines 213 213
Branches 15 15
=======================================
Hits 10 10
Misses 203 203Continue to review full report at Codecov.
|
janniclas
suggested changes
Jan 24, 2019
Contributor
janniclas
left a comment
janniclas
left a comment
There was a problem hiding this comment.
As seen in the image there are two visual issues left. On the one hand the button when clicked is half surrounded with this blue line.
And after adding the view details button the table is overflowing to the right, which is not desirable.
janniclas
suggested changes
Jan 24, 2019
Contributor
janniclas
left a comment
janniclas
left a comment
There was a problem hiding this comment.
please update the code according to the added comments
janniclas
approved these changes
Jan 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added table-row expansion feature. It expands the row of a table on clicking the "View Details" button to show the details of an instance such as docker Id and labels. The feature is implemented using Angular-Material table expand-row feature.