Skip to content

Conversation

@johannesduesing
Copy link

Reason for this PR
In #27 some HTTP libraries have been introduced to the project's build definition in an effort to move away from Akka HTTP. Three http4s libraries are still part of the file but unused. Also there is dangeling code from previous work on supporting GraalVM native image releases, which is also unused (see discussion below #27).

Changes in this PR

  • Removed build references to http4s-dsl, http4s-blaze-client and http4s-circe
  • Removed unused code that was reading environment variables in an effort to support GraalVM native image releases

@johannesduesing johannesduesing added this to the 0.9.6 milestone Jul 15, 2020
@johannesduesing johannesduesing requested a review from bhermann July 15, 2020 09:00
@johannesduesing johannesduesing self-assigned this Jul 15, 2020
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bhermann bhermann merged commit 8bef6b0 into develop Jul 15, 2020
@bhermann bhermann deleted the feature/http-lib-cleanup branch July 15, 2020 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants