Support for detailed error messages in case of query errors #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this PR
delphi-hub/delphi-webapi#59 introduces
400 Bad Requestresponses on client-side query errors, including detailed messages for syntactical / semantical errors. The CLI does not support those detailed error responses yet, and will simply print "Search Request Failed" on any non-200 response from the delphi-webapi.Changes in this PR
Whenever a
400 Bad Requestis returned by the delphi-webapi on executing thesearchcommand, the error message will be extracted from the response and printed to the console. In case of invalid field names in a query, an additional error output will display the invalid field names as a comma-seperated list.