forked from nginx/nginx-s3-gateway
-
Notifications
You must be signed in to change notification settings - Fork 1
Issue/165 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ivanitskiy
wants to merge
13
commits into
dekobon:issue/165
Choose a base branch
from
ivanitskiy:issue/165
base: issue/165
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Issue/165 #1
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
ed48f0f
Fixes #164
dekobon 073f613
Fixes #165
dekobon 0b74b35
chore: added eslint, prettier and misc jsdocs
ivanitskiy eab7944
format: fixed fmt and lint issues with prettier and eslint
ivanitskiy d6fb9b0
fix: use the same version of njs-types as NJS_VERSION
ivanitskiy 44d21d4
fixed reported problems VSC's eslint
ivanitskiy 8e2a1c4
chore: updated devDependencies eslint and prettier
ivanitskiy 0c42499
lint: remove node from eslintrc and use globals instead
ivanitskiy 016e9ee
lint: allow semi in .prettierrc.yml
ivanitskiy dd8854f
added prettier vsc code config for the project
ivanitskiy a6f32aa
chore: autoformat with prettier
ivanitskiy 4dae588
fix: r.variables comparisons
ivanitskiy ad606c7
ci: check format and lint code
ivanitskiy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
{ | ||
"extends": [ | ||
"eslint:recommended", | ||
"plugin:@typescript-eslint/recommended", | ||
"plugin:prettier/recommended" | ||
], | ||
"ignorePatterns": ["**/node_modules/", "out/**", "test/"], | ||
"parser": "@typescript-eslint/parser", | ||
"parserOptions": { | ||
"ecmaVersion": 2015, | ||
"sourceType": "module" | ||
}, | ||
"plugins": [ | ||
"@typescript-eslint" | ||
], | ||
"rules": { | ||
"@typescript-eslint/no-unused-vars": [ | ||
"warn", | ||
{ | ||
"argsIgnorePattern": "^_", | ||
"varsIgnorePattern": "^_", | ||
"caughtErrorsIgnorePattern": "^_" | ||
} | ||
] | ||
}, | ||
"root": true, | ||
"env": { | ||
"commonjs": true | ||
}, | ||
"globals": { | ||
"ngx": "readonly", | ||
"process": "readonly", | ||
"Buffer": "readonly" | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
name: Lint and format | ||
on: | ||
- push | ||
- pull_request | ||
|
||
jobs: | ||
lint: | ||
name: Lint and check code style | ||
runs-on: ubuntu-latest | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/setup-node@v3 | ||
- run: npm ci | ||
- run: npm run prettier | ||
- run: npm run eslint |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
{ | ||
"plugins": [ | ||
"node_modules/better-docs/typescript" | ||
], | ||
"source": { | ||
"include": ["./common/etc/nginx/include", "./node_modules/njs-types"], | ||
"includePattern": "\\.(jsx|js|ts|tsx)$", | ||
"excludePattern": "(^|\\/|\\\\)_" | ||
}, | ||
"opts": { | ||
"template": "./node_modules/better-docs", | ||
"readme": "README.md", | ||
"verbose": true | ||
} | ||
} | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# style settings, see https://prettier.io/docs/en/options.html | ||
semi: true | ||
singleQuote: true | ||
trailingComma: es5 | ||
tabWidth: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
nodejs 20.5.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"prettier.configPath": ".prettierrc.yml" | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.