-
Notifications
You must be signed in to change notification settings - Fork 7
Feat: add vacancy formation task #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces a new property calculation task for vacancy formation energy in inorganic materials. The implementation evaluates models' ability to predict the energy required to form oxygen vacancies in crystal structures.
Key Changes:
- Added vacancy formation energy calculation task with oxygen reference energy computation
- Integrated the new task into the evaluation pipeline with appropriate metrics
- Configured test data path and evaluation parameters
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
lambench/tasks/calculator/vacancy/vacancy.py | Core implementation of vacancy formation energy calculation with O2 reference energy |
lambench/tasks/calculator/calculator_tasks.yml | Configuration entry for the vacancy task with test data path |
lambench/models/ase_models.py | Integration of vacancy task into the ASEModel evaluation flow |
lambench/metrics/post_process.py | Added vacancy to the list of domain-specific tasks for post-processing |
lambench/metrics/downstream_tasks_metrics.yml | Defined metrics and dummy baseline for vacancy task evaluation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #370 +/- ##
==========================================
- Coverage 65.89% 65.72% -0.17%
==========================================
Files 35 35
Lines 1589 1593 +4
Branches 189 190 +1
==========================================
Hits 1047 1047
- Misses 500 504 +4
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This PR add a new property calculation task.