Skip to content

feat: Add Modular Session Key Plugin to samples directory #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jan 8, 2024
Merged

feat: Add Modular Session Key Plugin to samples directory #1

merged 23 commits into from
Jan 8, 2024

Conversation

@sm-stack
Copy link
Collaborator

@sm-stack sm-stack commented Jan 8, 2024

Motivation

  • Need for new samples directory for community-drive plugin development

Solution

  • Add samples directory
  • Migrate current session key implementation into samples directory

sm-stack and others added 23 commits November 9, 2023 12:44
@sm-stack
Add session key plugin and corresponding tests
0fb2113
@sm-stack
Fix name of execution function
e4b429c
@sm-stack
Refactor the logic of updating session key to include selector
f12a0ce
@sm-stack
Fix lint
c7fd76f
@sm-stack
Remove unused internal functions
f77df4c
@sm-stack
Update comments
57cf21d
@sm-stack
Fix prank overriding issue
3b63b0d
@sm-stack
Fix lint
e097c21
@sm-stack
Fix lint
d3ad5a7
@sm-stack
Merge branch 'main' into session-key
82fc8fe
@sm-stack
Merge branch 'main' into session-key
cfd4289
@sm-stack
Fix plugin codes to be compatible with the spec update
f2ad9a6
@sm-stack
Fix nits
f61b085
@sm-stack
Fix functionId
3e5d7fb
@sm-stack
Fix session key test corresponding to code changes
65e6d1a
@sm-stack
Add batch owner operations and additional error handling logics
f2a74ad
@sm-stack
Revert changes for pnpm-lock.yaml
b1367b5
@sm-stack
Remove unused dependencies at test
c12d26d
@sm-stack
Fix nits
3cb63a6
@sm-stack
Add onInstall and unOninstall function at TokenSessionKey.sol
2252299
@sm-stack
Fix format with forge fmt
4b99521
@sm-stack
Add smaples directory
d21659e
@sm-stack
Fix nits with forge fmt
76aa433
@sm-stack sm-stack requested a review from Sangyeup January 8, 2024 05:01
@sm-stack sm-stack self-assigned this Jan 8, 2024
Sangyeup
Sangyeup approved these changes Jan 8, 2024
View reviewed changes
Copy link

@Sangyeup Sangyeup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sm-stack LGTM!

@sm-stack sm-stack merged commit efb951f into sample-with-session-key Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sangyeup Sangyeup Sangyeup approved these changes

Assignees

@sm-stack sm-stack

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sm-stack @Sangyeup