`.Values.image.tag` does not override the image tag completely

[joshdcu]

The Helm chart allows us to override the image used by setting .Values.image.repository and .Values.image.tag accordingly. However, it always adds a v prefix to the tag which may not always be compatible, especially if users are using custom tags. Looking at the manifests where .Values.image is referenced, I see a Helm template is used:

charts/charts/db-operator/templates/controller/deployment.yaml

Line 45 in d941e9b

image: "{{ .Values.image.repository }}:{{ template "github_packages_image_version" . }}"

and

charts/charts/db-operator/templates/webhook/deployment.yaml

Line 44 in d941e9b

image: "{{ .Values.image.repository }}:{{ template "github_packages_image_version" . }}"

It is the Helm template which is adding the undesired v prefix:

charts/charts/db-operator/templates/_helpers.tpl

Lines 123 to 128 in d941e9b

	{{/*
	Image version definition using Github Packages format ('v' prefix);
	*/}}
	{{- define "github_packages_image_version" -}}
	{{- printf "v%s" (default .Chart.AppVersion .Values.image.tag) }}
	{{- end -}}

Can we please allow the .Values.image.tag to completely override the image tag? That would offer more flexibility to users.