-
Notifications
You must be signed in to change notification settings - Fork 0
feat: Add SQL linting with reviewdog suggestions #20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .sqlfluff: Language not supported
- database/sql/mysql/schema.sql: Language not supported
- database/sql/postgresql/schema.sql: Language not supported
- scripts/lint-sql.sh: Language not supported
- test-databases.sh: Language not supported
Comments suppressed due to low confidence (2)
database/mongodb/init.js:43
- The usage of UUID() in the insert document may cause runtime errors if UUID() is not defined in your MongoDB environment. Consider using a well-supported UUID generation method or the native ObjectId to ensure consistent behavior.
_id: UUID().toString(),
.github/workflows/database-tests.yml:47
- [nitpick] The use of double quotes in the --format parameter may lead to shell parsing issues. Consider using single quotes around the format string (e.g., '--format "{{.ExitCode}}"') to avoid potential interpolation problems.
EXIT_CODE=$(docker compose ps -a --format "{{.ExitCode}}" test)
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 9 out of 14 changed files in this pull request and generated no comments.
Files not reviewed (5)
- .sqlfluff: Language not supported
- database/sql/mysql/schema.sql: Language not supported
- database/sql/postgresql/schema.sql: Language not supported
- scripts/lint-sql.sh: Language not supported
- test-databases.sh: Language not supported
Comments suppressed due to low confidence (1)
database/mongodb/init.js:43
- Ensure that 'new UUID()' is supported in the MongoDB shell environment; if not, consider using the standard UUID() function or another reliable UUID generation method.
_id: new UUID().toString(),
This PR adds SQL linting capabilities with automated code suggestions using reviewdog.
Changes
Features
How to Use
In Pull Requests:
Locally:
Closes #1