-
Notifications
You must be signed in to change notification settings - Fork 79
refactor(array): split array.rs types into smaller files #529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ad84928
to
efbaa8d
Compare
Pull Request Test Coverage Report for Build 16392720284Details
💛 - Coveralls |
Thanks. This is pretty much what I had in mind. Would further split the conversions though, as I see them growing in the future. Something like
|
b4f199b
to
4584989
Compare
I've created a |
4584989
to
e9eef59
Compare
I would keep it in the |
e9eef59
to
59012d2
Compare
Thanks, looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohh, just noticed. Mind moving the tests into the vec conversion module?
59012d2
to
3e31758
Compare
I split the tests, sorry. |
3e31758
to
d2601bc
Compare
Description
A dummy split only here, but not sure about naming.