Skip to content

Conversation

ptondereau
Copy link
Collaborator

@ptondereau ptondereau commented Jul 19, 2025

Description

A dummy split only here, but not sure about naming.

@ptondereau ptondereau linked an issue Jul 19, 2025 that may be closed by this pull request
@ptondereau ptondereau force-pushed the refator/split-array-type branch 3 times, most recently from ad84928 to efbaa8d Compare July 19, 2025 20:08
@coveralls
Copy link

coveralls commented Jul 19, 2025

Pull Request Test Coverage Report for Build 16392720284

Details

  • 79 of 299 (26.42%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 24.784%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array/array_key.rs 17 31 54.84%
src/types/array/conversions/hash_map.rs 0 18 0.0%
src/types/array/conversions/vec.rs 25 43 58.14%
src/types/array/iterators.rs 14 78 17.95%
src/types/array/mod.rs 23 129 17.83%
Totals Coverage Status
Change from base Build 16376309774: 0.0%
Covered Lines: 976
Relevant Lines: 3938

💛 - Coveralls

@Xenira
Copy link
Collaborator

Xenira commented Jul 19, 2025

Thanks. This is pretty much what I had in mind. Would further split the conversions though, as I see them growing in the future.

Something like

hash_map.rs
vec.rs
btree_map.rs
hash_set.rs
indexmap.rs
[...]

@ptondereau ptondereau force-pushed the refator/split-array-type branch 2 times, most recently from b4f199b to 4584989 Compare July 19, 2025 20:26
@ptondereau
Copy link
Collaborator Author

Thanks. This is pretty much what I had in mind. Would further split the conversions though, as I see them growing in the future.

Something like

hash_map.rs
vec.rs
btree_map.rs
hash_set.rs
indexmap.rs
[...]

I've created a conversions sub module and I don't know if from_iterator.rs should be part of iterator.rs or should be living alone.

@ptondereau ptondereau force-pushed the refator/split-array-type branch from 4584989 to e9eef59 Compare July 19, 2025 20:30
@Xenira
Copy link
Collaborator

Xenira commented Jul 19, 2025

I would keep it in the iterator.rs for now. Don't see it growing that much rn and it fits better in there.

@ptondereau ptondereau force-pushed the refator/split-array-type branch from e9eef59 to 59012d2 Compare July 19, 2025 20:35
@ptondereau ptondereau marked this pull request as ready for review July 19, 2025 20:37
@ptondereau ptondereau requested a review from Xenira July 19, 2025 20:37
@Xenira
Copy link
Collaborator

Xenira commented Jul 19, 2025

Thanks, looks good!

Copy link
Collaborator

@Xenira Xenira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh, just noticed. Mind moving the tests into the vec conversion module?

@ptondereau ptondereau force-pushed the refator/split-array-type branch from 59012d2 to 3e31758 Compare July 19, 2025 20:56
@ptondereau
Copy link
Collaborator Author

Ohh, just noticed. Mind moving the tests into the vec conversion module?

I split the tests, sorry.

@ptondereau ptondereau requested a review from Xenira July 19, 2025 20:57
@ptondereau ptondereau force-pushed the refator/split-array-type branch from 3e31758 to d2601bc Compare July 19, 2025 21:04
@ptondereau ptondereau requested a review from Xenira July 19, 2025 21:16
@Xenira Xenira merged commit 9c1285b into master Jul 19, 2025
57 checks passed
@Xenira Xenira deleted the refator/split-array-type branch July 19, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split types/array.rs

3 participants