Skip to content

Conversation

Xenira
Copy link
Collaborator

@Xenira Xenira commented Jul 15, 2025

Refs: #425

Description

HashMap<K,V> looses ordering information.
This will add support for Vec<(K,V)>. Index map will be added in separate pr.

Checklist

Check the boxes that apply (put an x in the brackets, like [x]). You can also check boxes after the PR is created.

❤️ Thank you for your contribution!

@Xenira Xenira linked an issue Jul 15, 2025 that may be closed by this pull request
@Xenira Xenira force-pushed the 425-add-indexmap-feature-as-hashmapstring-zval-does-not-guarantee-same-order-as-input-from-php branch 2 times, most recently from 2d6083e to 78d1259 Compare July 15, 2025 16:13
@coveralls
Copy link

coveralls commented Jul 15, 2025

Pull Request Test Coverage Report for Build 16350571405

Details

  • 35 of 37 (94.59%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.3%) to 24.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/types/array.rs 35 37 94.59%
Totals Coverage Status
Change from base Build 16276541582: 2.3%
Covered Lines: 968
Relevant Lines: 3934

💛 - Coveralls

@Xenira Xenira force-pushed the 425-add-indexmap-feature-as-hashmapstring-zval-does-not-guarantee-same-order-as-input-from-php branch from 78d1259 to daf1560 Compare July 17, 2025 16:25
@Xenira Xenira marked this pull request as ready for review July 17, 2025 16:32
@Xenira Xenira changed the title Support for ordered hash tables feat(array): support Vec<(K,V)> for hashtables Jul 17, 2025
@Xenira Xenira merged commit 2a0d615 into master Jul 17, 2025
57 checks passed
@Xenira Xenira deleted the 425-add-indexmap-feature-as-hashmapstring-zval-does-not-guarantee-same-order-as-input-from-php branch July 17, 2025 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Vec<(K,V)> to preserve insert order.

2 participants