Php enums

[estk]

Hi @davidcole1340,
I'm wondering why php 8 enums were not implemented, is there some issue with defining an enum in an extension?
Asking because I am currently working on it and would be interested in upstreaming the change.

[davidcole1340]

No reason -- I just haven't had time to do it. PRs are greatly appreciated if you are working on it!

Some references if you would like to have a look:

• https://github.com/php/php-src/blob/f6c9a90e19d648355c39da84af9bc59b2ff60c15/Zend/zend_enum.c#L480-L509
• https://github.com/php/php-src/blob/f6c9a90e19d648355c39da84af9bc59b2ff60c15/ext/zend_test/test_arginfo.h#L575-L636

[estk]

Excellent, thanks @davidcole1340. I should have a PR for you shortly. Also, thanks for the refs, especially the test ref, I didn't know that existed.

[joehoyle]

Given enums were added in PHP 8.1, I'm not sure the best way to handle the optionality of them. Should this maybe be a cargo feature?

[danog]

I'd rather just bump the minimum version, since PHP 8.0 has already stopped receiving security updates.

[Xenira]

@joehoyle I know that we have spoken about this, but was not aware of this at that time.

Not sure how hard this would break 8.0, but I'd rather remove support entirely then have it maybe work.
If someone really needs to compile against an old php version they can still build from src and tinker to get it working.

As long as we are upfront on how long a given version is supported we should be fine removing old ones.
This not only allows us to add newer features more easily, but reduces maintainance.